Validate code when scheduling upgrades from registrar #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Feb 6, 2024
s0me0ne-unkn0wn
approved these changes
Feb 11, 2024
eskimor
approved these changes
Feb 13, 2024
bkchr
added
the
T8-polkadot
bkchr
reviewed
Feb 13, 2024
Comment on lines
1235
to
1237
| // Validation code sanity checks: | ||
| ensure!(new_code.check_sanity(), Error::<T>::InvalidCode); | ||
| ensure!(new_code.0.len() <= config.max_code_size as usize, Error::<T>::InvalidCode); |
There was a problem hiding this comment.
I still think that this should be moved to schedule_code_upgrade.
bkchr
approved these changes
Feb 14, 2024
🙈Should be good now. |
Merged
via the queue into
paritytech:master
with commit Feb 14, 2024
7e7c488
122 of 124 checks passed
This was referenced Jun 5, 2024
ggwpez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, anyone can registrar a code that exceeds the code size limit when performing the upgrade from the registrar. This PR fixes that and adds a new test to cover this.
cc @bkchr @eskimor